Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] Switch from webpack and babel to vite #3030

Closed
wants to merge 1 commit into from
Closed

[DO NOT MERGE] Switch from webpack and babel to vite #3030

wants to merge 1 commit into from

Conversation

AlanGreene
Copy link
Member

Changes

NOTE: This PR is not intended to be merged in its current state. It will be used for discussion about potential changes to the Dashboard, its build process, user-facing enhancements, etc.

Any accepted changes will then be separated out and PRs submitted with the usual documentation, tests, etc.

This is still a work in progress, not all features and functionality have been tested.

TODO:

  • compare bundle content + sizes (JS chunks seem bigger)
  • verify Carbon styling (dark mode, hover states, etc.)
  • split chunks (started with YAMLEditor)
  • verify impact on consumers of the packages
  • … ?

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (new features, significant UI changes, API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 8, 2023
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 8, 2023
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from alangreene after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 8, 2023
@AlanGreene

This comment was marked as resolved.

Sign in to view
@AlanGreene AlanGreene force-pushed the POC_vite branch 2 times, most recently from 77038b2 to d7534ef Compare August 8, 2023 14:52
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 8, 2023
@AlanGreene

This comment was marked as resolved.

Sign in to view
@AlanGreene

This comment was marked as resolved.

Sign in to view
@AlanGreene

This comment was marked as resolved.

Sign in to view
@AlanGreene

This comment was marked as resolved.

Sign in to view
@AlanGreene

This comment was marked as resolved.

Sign in to view
@AlanGreene

This comment was marked as resolved.

Sign in to view
@AlanGreene
wip: Switch from webpack and babel to vite
04f44bd 
TODO:
- compare bundle content + sizes (JS chunks seem bigger)
- verify Carbon styling (dark mode, hover states, etc.)
- split chunks (started with YAMLEditor)
- … ?
@AlanGreene AlanGreene mentioned this pull request Aug 10, 2023
Merged
7 tasks
@AlanGreene
Copy link
Member Author

Most of this has been covered by #3031 and #3032, the only things remaining are the common Loading component and lazy-loading the YAMLEditor.

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 11, 2023
@tekton-robot
Copy link
Contributor

@AlanGreene: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AlanGreene AlanGreene mentioned this pull request Aug 12, 2023
Merged
7 tasks
@AlanGreene AlanGreene deleted the POC_vite branch August 14, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlanGreene @tekton-robot